RenameFile

DogmaDragon · August 29, 2026, 9:59pm

fix(RenameFile): fix doubled file extension causing 'File name too long' error

main ← garfolino:renamefile-fix-long-filename-macos

opened 09:08PM - 29 Aug 26 UTC

Fixes #767 **Depends on #733** — this branch is built on top of `fix/renamefile…-title-stuck` (which bumps `RenameFile` to 1.0.1), so this PR's diff includes that PR's commit and bumps the version again to 1.0.2 on top of it. GitHub doesn't allow targeting a base branch that only exists in a fork, so this still shows as based on `main`; please merge/land #733 first, or review this diff as the two commits after `785fa73`. ### Summary - Fix the long-filename truncation fallback in `RenameFile` so it no longer doubles the file extension and correctly reserves space for the hash suffix, which was causing `OSError: [Errno 63] File name too long` (macOS) / `ENAMETOOLONG` when renaming scenes whose formatted filename exceeded `max_filename_length`. - When a rename/move does fail, stop the OSError from being re-raised into the top-level catch-all (which dumped a full Python traceback into the log on top of the already-logged clear error message). - Bump plugin version to 1.0.2 (on top of #733's 1.0.1) and update the changelog. ### Root cause See #767 for the full analysis. In short: the truncation branch built `new_filename` as `truncated + '_' + hash + extension`, but the length budget it truncated to only subtracted the extension length (not the `_`+hash), and the caller then appended the extension a second time (`newFilenameWithExt = new_filename + suffix`), producing filenames like `....mp4.mp4` well past `max_filename_length`. ### Testing - Reproduced the exact reported failure by hand: recomputed the original 292-character doubled-extension filename from the logged error and confirmed the new logic instead produces a name at or under the configured `max_filename_length`, with a single extension. - Ran the repo's plugin validator (`node ./validator/index.js --ci`) — passes. - Not yet exercised against a live Stash instance with an actual over-long title/tag combination; recommend a maintainer or the reporter re-test the original scenario before merge. ### AI disclosure This fix (analysis, code changes, issue text, and this PR description) was drafted with LLM (Claude) assistance from a real user-reported error log. The diff was reviewed by a human before submission, per the repo's LLM-assisted contribution policy.

@David-Maisonave would you be interested in reviewing it?